Little fixes and improvements in documentation#279
Little fixes and improvements in documentation#279xlamorlette-datadog wants to merge 9 commits intomainfrom
Conversation
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
had a problem deploying
to
dev
GitHub Actions
Failure
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
BenchmarksBenchmark execution time: 2026-03-16 17:48:43 Comparing candidate commit e4632e0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 84 84
Lines 5668 5668
=======================================
Hits 4971 4971
Misses 697 697 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
temporarily deployed
to
dev
GitHub Actions
Inactive
xlamorlette-datadog
force-pushed
the
xlamorlette/documentation-improvements
branch
from
e22402a to
482c52d
Compare
xlamorlette-datadog
requested review from
zacharycmontoya
and removed request for
a team
xlamorlette-datadog
changed the title
README.md
Outdated
|
|
||
| Code coverage reports are available [here][2]. | ||
| Code coverage reports, run on pull requests, are available | ||
| [in Datadog](https://app.datadoghq.com/ci/code-coverage/github.com%2Fdatadog%2Fdd-trace-cpp/pull-requests). |
There was a problem hiding this comment.
This link is not publicly accessible, whereas the previous one was. We should probably leave that link as-is for now
There was a problem hiding this comment.
I put the link in our internal 'APM C++' Confluence page.
| process_arg "$arg" | ||
| done | xargs -0 \ | ||
| docker run \ | ||
| --platform linux/amd64 \ |
There was a problem hiding this comment.
Do you have an arm64 machine to test if this will still work for an Apple Silicon dev environment?
There was a problem hiding this comment.
I introduced this so that it works on my MacBook M3, because the used silkeh/clang:14 Docker image doesn't exist for arm64, it only exists for amd64. I'm going to add a comment about this.
This --platform option of docker run forces the usage of an amd64 image from an arm64 machine.
3 participants
Description
bin/formatso that it runs locally.@DataDog/cpp-reviewersas code owners (to get automatic notifications for PRs).Motivation
Additional Notes